Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid not specialized Pair issue #2889

Merged
merged 2 commits into from
Sep 23, 2021
Merged

avoid not specialized Pair issue #2889

merged 2 commits into from
Sep 23, 2021

Conversation

bkamins
Copy link
Member

@bkamins bkamins commented Sep 22, 2021

Fixes #2888

@bkamins bkamins added the bug label Sep 22, 2021
@bkamins bkamins added this to the 1.3 milestone Sep 22, 2021
nalimilan
nalimilan approved these changes Sep 23, 2021
View reviewed changes
src/abstractdataframe/selection.jl Outdated Show resolved Hide resolved
test/select.jl Outdated Show resolved Hide resolved
@bkamins @nalimilan
Apply suggestions from code review
83b7da3 
Co-authored-by: Milan Bouchet-Valat <nalimilan@club.fr>
@bkamins bkamins merged commit 7fcb93b into main Sep 23, 2021
@bkamins bkamins deleted the bk/concrete_pair branch September 23, 2021 19:15
@bkamins
Copy link
Member Author

bkamins commented Sep 23, 2021

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nalimilan nalimilan nalimilan approved these changes

@pdeffebach pdeffebach Awaiting requested review from pdeffebach

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.

mixing :x => :y and :x => f => :y syntax in vector to select errors
2 participants
@bkamins @nalimilan